Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charset not useful when Content-Type is multipart/form-data #374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guange2015
Copy link

No description provided.

@newmanw
Copy link

newmanw commented Dec 3, 2013

Why has this not been pulled into the baseline?

@jogu
Copy link
Collaborator

jogu commented Dec 3, 2013

@newmanw Probably because ASIHTTPRequest is pretty much dead.

I think I'm possibly the only person still merging things (and I don't have any projects left myself that use ASIHTTPRequest), and I'm definitely trying to veer towards not breaking things. If someone could explain why charset isn't useful / what removing it fixes / why it was added originally that might help twist my arm into looking at it.

I'm also not sure about adding a podspec - ASIHTTPRequest really shouldn't be used in new projects.

@newmanw
Copy link

newmanw commented Dec 3, 2013

New to iOS, is there a good alternative? Seems like async http should be built into core iOS (and maybe it is).

@jogu
Copy link
Collaborator

jogu commented Dec 3, 2013

It is :-) NSURLConnection is the underlying iOS/Mac class. A large number of people use AFNetworking, which is a wrapper around NSUrlConnection etc, but there are other wrappers too.

@newmanw
Copy link

newmanw commented Dec 3, 2013

Perfect thanks for your help! i don't think there is a need to pull that in. I modified my copy of the code locally in my project to work. Long term goal is to use the core libs or a non-dead framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants